Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node E2E: Create new ubuntu image with docker 1.12.6. #40884

Merged
merged 1 commit into from
Feb 3, 2017
Merged

Node E2E: Create new ubuntu image with docker 1.12.6. #40884

merged 1 commit into from
Feb 3, 2017

Conversation

Random-Liu
Copy link
Member

We should test the newest docker 1.12 version - 1.12.6.

/cc @dchen1107 @yujuhong @kubernetes/sig-node-pr-reviews

@Random-Liu Random-Liu added area/docker area/node-e2e sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 2, 2017
@Random-Liu Random-Liu added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 2, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2017
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: Random-Liu

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2017
@yujuhong
Copy link
Contributor

yujuhong commented Feb 2, 2017

/lgtm

/cc @justinsb, I thought we were testing 1.12.6 in the node e2e, but I was wrong. This PR will update the ubuntu image to use 1.12.6 and test it properly.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2017
@Random-Liu
Copy link
Member Author

Random-Liu commented Feb 2, 2017 •
edited

@k8s-bot kubemark e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 40884, 40809, 40845, 40866, 40875)

@k8s-github-robot k8s-github-robot merged commit 7201f3b into kubernetes:master Feb 3, 2017
@Random-Liu Random-Liu deleted the update-to-docker-1-12-6 branch February 3, 2017 03:30
@Random-Liu Random-Liu mentioned this pull request Feb 15, 2017
Merged
@saad-ali saad-ali added this to the v1.5 milestone Feb 16, 2017
@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Feb 16, 2017
k8s-github-robot pushed a commit that referenced this pull request Feb 16, 2017
Merge pull request #41448 from Random-Liu/automated-cherry-pick-of-#4…
19d320d 
…0884-upstream-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #40884

Cherry pick of #40884 on release-1.5.

#40884: Node E2E: Create new ubuntu image with docker 1.12.6.
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docker area/node-e2e cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Random-Liu @k8s-reviewable @k8s-github-robot @yujuhong @k8s-cherrypick-bot @saad-ali @k8s-ci-robot